Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1827623002: Supress gn check error in proxy_config_service_linux.cc (Closed)

Created:
4 years, 9 months ago by haibinlu
Modified:
4 years, 9 months ago
Reviewers:
davidben, Wez
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supress gn check error in proxy_config_service_linux.cc Background on nogncheck https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/ctwaYl__aaQ/u12ZIlv21gIJ BUG=596706 Committed: https://crrev.com/a872526808bc606a6e0df788131de626eaaeea82 Cr-Commit-Position: refs/heads/master@{#382719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/proxy/proxy_config_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
haibinlu
4 years, 9 months ago (2016-03-22 21:39:23 UTC) #2
davidben
lgtm
4 years, 9 months ago (2016-03-22 21:54:11 UTC) #3
Wez
LGTM, but I'd suggest rather than linking to a lengthy forum post just update the ...
4 years, 9 months ago (2016-03-22 22:06:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827623002/1
4 years, 9 months ago (2016-03-22 22:10:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 22:58:43 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:59:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a872526808bc606a6e0df788131de626eaaeea82
Cr-Commit-Position: refs/heads/master@{#382719}

Powered by Google App Engine
This is Rietveld 408576698