Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1827583002: S390: [es6] Faster implementation of OrdinaryHasInstance. (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [es6] Faster implementation of OrdinaryHasInstance. Port b6419fa2298de8e292c6bed0bd20de5c96f7da12 Original commit message: Now implemented as a builtin that delegates to the InstanceOfStub. That stub was parameterized to fallback to either Runtime_InstanceOf or to Runtime_OrdinaryHasInstance depending on the --harmony-instanceof flag. Once the feature stabilizes and the flag is no longer needed, we can get rid of this parameterization again. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4447 LOG=n Committed: https://crrev.com/91468c2e6c561cd201eac38cd627b0e740ee4b11 Cr-Commit-Position: refs/heads/master@{#35025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/s390/builtins-s390.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 9 months ago (2016-03-22 20:38:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827583002/1
4 years, 9 months ago (2016-03-22 20:38:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 20:56:42 UTC) #5
Michael Starzinger
LGTM. Thanks!
4 years, 9 months ago (2016-03-23 08:22:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827583002/1
4 years, 9 months ago (2016-03-23 12:49:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 12:51:18 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 12:51:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91468c2e6c561cd201eac38cd627b0e740ee4b11
Cr-Commit-Position: refs/heads/master@{#35025}

Powered by Google App Engine
This is Rietveld 408576698