third_party/WebKit/Source/core/html/shadow/MediaControls.cpp - Issue 1827573004: Allow play/pause on default controls to clear media errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 1827573004: Allow play/pause on default controls to clear media errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable MediaSource and MediaStream URLs. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp ('K') | « third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

index 4e619ec06969922a5c0a691831df4a392867126f..20e2edbd502485a4a69b1295ea7913f02e9f426e 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

@@ -252,6 +252,10 @@ void MediaControls::reset()

m_timeline->setIsWanted(true);

}

+ // If the player has entered an error state, force it into the paused state.

+ if (mediaElement().error())

+ mediaElement().pause();

updatePlayState();

updateCurrentTimeDisplay();