Allow play/pause on default controls to clear media errors.

third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 266 matching lines @@
     RefPtrWillBeRawPtr<MediaControlPlayButtonElement> button = adoptRefWillBeNoop(new MediaControlPlayButtonElement(mediaControls));
     button->ensureUserAgentShadowRoot();
     button->setType(InputTypeNames::button);
     button->setShadowPseudoId(AtomicString("-webkit-media-controls-play-button", AtomicString::ConstructFromLiteral));
     return button.release();
 }
 
 void MediaControlPlayButtonElement::defaultEventHandler(Event* event)
 {
     if (event->type() == EventTypeNames::click) {
+        if (mediaElement().error())
+            mediaElement().load();

[philipj_slow, 2016/03/24 07:00:05]

I think an error doesn't actually set paused to true, at least I can't see where
that happens. So it might happen that this still looks like a pause button, but
pressing it reloads and plays. Better than nothing of course, but is that what
you were hoping for?

Something to consider could be a "play again" icon, which is used at the end of
playback and also after an error. That way it'd be a bit more obvious what the
button does before clicking it. We have that as an overlay button in Opera for
Android, something I'd like to upstream. I don't think that needs to block this
CL of course, but do you think it would make sense?

[DaleCurtis, 2016/03/24 18:50:16]

Ah, I thought that was a bug, I was going to hunt it down today. You're correct
that it is stuck in the paused state when it dies. Errors do cause a reset of
the controls though, so we could have them toggle the paused / error state when
MediaControls::reset() is called.

I agree that we should have some iconography here. Either Opera's button or
reach out to the visual design team for a new material design button. Play again
sounds like a good choice. Though, I actually like the idea of a tiny sad
tab-like play button. Might be useful in differentiating reports from users. 

I don't think we need to make any update in this CL though -- especially since
desktop and mobile controls are different at present. I'd prefer to make any
updates after we've removed the old controls or limit them to the new UI.

+
         mediaElement().togglePlayState();
         updateDisplayType();
         event->setDefaultHandled();
     }
     HTMLInputElement::defaultEventHandler(event);
 }
 
 void MediaControlPlayButtonElement::updateDisplayType()
 {
     setDisplayType(mediaElement().paused() ? MediaPlayButton : MediaPauseButton);
@@ skipping 352 matching lines @@
 }
 
 PassRefPtrWillBeRawPtr<MediaControlCurrentTimeDisplayElement> MediaControlCurrentTimeDisplayElement::create(MediaControls& mediaControls)
 {
     RefPtrWillBeRawPtr<MediaControlCurrentTimeDisplayElement> element = adoptRefWillBeNoop(new MediaControlCurrentTimeDisplayElement(mediaControls));
     element->setShadowPseudoId(AtomicString("-webkit-media-controls-current-time-display", AtomicString::ConstructFromLiteral));
     return element.release();
 }
 
 } // namespace blink