Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1827563003: Revert of [counters] adding runtime call timers for GC (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
Reviewers:
ulan, Camillo Bruni
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [counters] adding runtime call timers for GC (patchset #4 id:60001 of https://codereview.chromium.org/1825093002/ ) Reason for revert: [Sheriff] ASAN bot is really badass today: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10844 Original issue's description: > [counters] adding runtime call timers for GC > > Adding an additional timer for the GC to make the other runtime call counters > more stable. > > BUG= > > Committed: https://crrev.com/9ec649638d553a891b0356155f4f15f3a260c1af > Cr-Commit-Position: refs/heads/master@{#35033} TBR=ulan@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a1521c90d54bf4cdaaf4c6ae549d297d5779ac08 Cr-Commit-Position: refs/heads/master@{#35034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/counters.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 4 chunks +1 line, -5 lines 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [counters] adding runtime call timers for GC
4 years, 9 months ago (2016-03-23 15:37:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827563003/1
4 years, 9 months ago (2016-03-23 15:37:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 15:37:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a1521c90d54bf4cdaaf4c6ae549d297d5779ac08 Cr-Commit-Position: refs/heads/master@{#35034}
4 years, 9 months ago (2016-03-23 15:39:13 UTC) #6
Michael Achenbach
4 years, 9 months ago (2016-03-23 16:02:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1826833002/ by machenbach@chromium.org.

The reason for reverting is: Reverting doesn't help here :/ Will disable the
test..

Powered by Google App Engine
This is Rietveld 408576698