Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: tools/dm_flags.py

Issue 1827543002: fix --threads 4, blacklist interlaced1,2,3 on GPU (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 1d9034b540fae9c289774182b84525931646afce..0509eb5d7227c0db57857a4c96e6ff489ecf0678 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -32,7 +32,7 @@ def get_args(bot):
# 32-bit desktop bots tend to run out of memory, because they have relatively
# far more cores than RAM (e.g. 32 cores, 3G RAM). Hold them back a bit.
if '-x86-' in bot and not 'NexusPlayer' in bot:
- args.append('--threads 4')
+ args.extend('--threads 4'.split(' '))
configs = ['565', '8888', 'gpu']
@@ -187,8 +187,12 @@ def get_args(bot):
"ARW", "CR2", "DNG", "NEF", "NRW", "ORF", "RAF", "RW2", "PEF", "SRW"]
# skbug.com/4888
- # Blacklist RAW images on GPU tests until we can resolve failures
+ # Blacklist RAW images (and a few large PNGs) on GPU bots
+ # until we can resolve failures
if 'GPU' in bot:
+ blacklist.extend('_ image _ interlaced1.png'.split(' '))
+ blacklist.extend('_ image _ interlaced2.png'.split(' '))
+ blacklist.extend('_ image _ interlaced3.png'.split(' '))
for raw_ext in r:
blacklist.extend(('_ image _ .%s' % raw_ext).split(' '))
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698