Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 18275002: Basic error checking for debugger GL widget. (Closed)

Created:
7 years, 5 months ago by bungeman-skia
Modified:
7 years, 5 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Basic error checking for debugger GL widget. Currently the debugger segfaults if the GL context cannot be created. This change allows the debugger to build with GL support, but still run if the GL context cannot be created at runtime. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M debugger/QT/SkGLWidget.cpp View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
I was Chromoting over the weekend and found it rather annoying that debugger would crash. ...
7 years, 5 months ago (2013-06-29 20:51:27 UTC) #1
robertphillips
lgtm
7 years, 5 months ago (2013-06-30 17:20:36 UTC) #2
bungeman-skia
7 years, 5 months ago (2013-07-01 13:54:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9834 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698