Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1827483002: Revert of Implement content_decoder_tool.cc to decode offline any resources. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pasko, gabadie, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement content_decoder_tool.cc to decode offline any resources. (patchset #4 id:60001 of https://codereview.chromium.org/1767653002/ ) Reason for revert: Broke iOS build: https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/44002 Original issue's description: > Implement content_decoder_tool.cc to decode offline any resources. > > Sandwich is going to use the HTMLPreloadScanner to get all the > resources to prefetch instead of using the Clovis' dependency > graph. However resources in the chrome HTTP cache or in the WPR > archive are stored as transport layer content, implying that they > might be stored using a compression algorithm, according to the > Content-Encoding response header. > > This tools enable us to decode any resources using the same very > code path used in chrome, implying that we will be able to > uncompressed absolutely all resources that chrome can and is > advertising in its Accept-Encoding request header. > > BUG=582080 > > Committed: https://crrev.com/4dc1dc6668a87620574dd43392046c3691914da2 > Cr-Commit-Position: refs/heads/master@{#382599} TBR=pasko@chromium.org,gavinp@chromium.org,gabadie@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582080 Committed: https://crrev.com/efc57ff133fe8722379d1f93d2accc4c8dfd4c7a Cr-Commit-Position: refs/heads/master@{#382606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -103 lines) Patch
M net/net.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
D net/tools/content_decoder_tool/content_decoder_tool.cc View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dgozman
Created Revert of Implement content_decoder_tool.cc to decode offline any resources.
4 years, 9 months ago (2016-03-22 17:56:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827483002/1
4 years, 9 months ago (2016-03-22 17:56:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 17:57:17 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 17:59:15 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efc57ff133fe8722379d1f93d2accc4c8dfd4c7a
Cr-Commit-Position: refs/heads/master@{#382606}

Powered by Google App Engine
This is Rietveld 408576698