Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827473002: Make the process-wide ServiceRegistry available to JS. (Closed)

Created:
4 years, 9 months ago by Sam McNally
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, extensions-reviews_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin-cc_chromium.org, arv+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the process-wide ServiceRegistry available to JS. BUG=597465 Committed: https://crrev.com/3f06742ebe125991b2c893638063cf8df55d8a86 Cr-Commit-Position: refs/heads/master@{#383008}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -31 lines) Patch
M chrome/browser/resources/engagement/site_engagement.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/omnibox/omnibox.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugins.js View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/test/data/web_ui_mojo.js View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/web_ui_mojo_shell_test.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/keep_alive.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/mime_handler_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/serial_service.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/stash_client.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/api_test_base_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/data_sender_unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/harness-tests/mojo-helpers.html View 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sam McNally
4 years, 9 months ago (2016-03-22 22:24:18 UTC) #3
jam
lgtm is there a tracking bug for this work? seems like there should be
4 years, 9 months ago (2016-03-23 15:14:19 UTC) #4
Sam McNally
On 2016/03/23 15:14:19, jam wrote: > lgtm > > is there a tracking bug for ...
4 years, 9 months ago (2016-03-24 00:33:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827473002/20001
4 years, 9 months ago (2016-03-24 00:34:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-24 01:44:24 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 01:45:58 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3f06742ebe125991b2c893638063cf8df55d8a86
Cr-Commit-Position: refs/heads/master@{#383008}

Powered by Google App Engine
This is Rietveld 408576698