Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1827463003: [stubs] Allow branch combining for Smi overflow checks. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
epertoso, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Allow branch combining for Smi overflow checks. The value projection of the Add/SubWithOverflow must be scheduled after the Branch that dispatches based on overflow in order for the instruction selector to be able to combine the addition/subtraction with the branching. R=epertoso@chromium.org Committed: https://crrev.com/208415d6e065a6b8ffdde4f5ca4629228abe9a46 Cr-Commit-Position: refs/heads/master@{#35011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/code-stubs.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-22 19:15:32 UTC) #1
Benedikt Meurer
Hey Enrico, Simple follow-up optimization. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-22 19:16:05 UTC) #2
Jarin
lgtm
4 years, 9 months ago (2016-03-23 05:29:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827463003/1
4 years, 9 months ago (2016-03-23 05:29:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 05:46:53 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 05:47:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/208415d6e065a6b8ffdde4f5ca4629228abe9a46
Cr-Commit-Position: refs/heads/master@{#35011}

Powered by Google App Engine
This is Rietveld 408576698