Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1827453002: Handful of changes to get mus to shutdown correctly (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handful of changes to get mus to shutdown correctly As part of https://codereview.chromium.org/1819063002/ we're trying to make mus shutdown cleanly (it currently does an exit). There are a handful of places causing problems: . GpuState::control_task_runner() could try to get the task runner from the thread after the thread has been shutdown, which results in trying to use a null value. By caching the TaskRunner we ensure you can't get null. . GpuState needs to shutdown the driver_manager_ on the gpu thread (driver_manager_ isn't thread safe). . Had to add a couple of checks for the MessageLoop as it may no longer be around. . Made the WindowServer be destroyed before stopping GpuThreads. If we don't destroy in this order StopThreads never completes. . Made PlatfromDisplay not notify delegate from destructor. BUG=none TEST=covered by tests R=fsamuel@chromium.org Committed: https://crrev.com/571d9ef9a6b91d606dcf00d493b22f32f96ffa45 Cr-Commit-Position: refs/heads/master@{#382645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M components/mus/gles2/gpu_state.h View 2 chunks +7 lines, -1 line 0 comments Download
M components/mus/gles2/gpu_state.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M components/mus/mus_app.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M components/mus/ws/platform_display.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-22 17:20:13 UTC) #1
Fady Samuel
lgtm
4 years, 9 months ago (2016-03-22 17:27:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827453002/1
4 years, 9 months ago (2016-03-22 17:28:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 19:39:57 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 19:41:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/571d9ef9a6b91d606dcf00d493b22f32f96ffa45
Cr-Commit-Position: refs/heads/master@{#382645}

Powered by Google App Engine
This is Rietveld 408576698