src/effects/SkDropShadowImageFilter.cpp - Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDropShadowImageFilter.cpp

Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkDropShadowImageFilter.cpp

diff --git a/src/effects/SkDropShadowImageFilter.cpp b/src/effects/SkDropShadowImageFilter.cpp

index deece35b3883fe9255ba9f0f926a3e1602093da3..e32b89ee6df8d92cfd8ad1d8486e781a62fd4f49 100644

--- a/src/effects/SkDropShadowImageFilter.cpp

+++ b/src/effects/SkDropShadowImageFilter.cpp

@@ -79,11 +79,9 @@

sigma.fX = SkMaxScalar(0, sigma.fX);

sigma.fY = SkMaxScalar(0, sigma.fY);

SkAutoTUnref<SkImageFilter> blurFilter(SkBlurImageFilter::Create(sigma.fX, sigma.fY));

- SkAutoTUnref<SkColorFilter> colorFilter(

- SkColorFilter::CreateModeFilter(fColor, SkXfermode::kSrcIn_Mode));

SkPaint paint;

paint.setImageFilter(blurFilter.get());

- paint.setColorFilter(colorFilter.get());

+ paint.setColorFilter(SkColorFilter::MakeModeFilter(fColor, SkXfermode::kSrcIn_Mode));

paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);

SkVector offsetVec = SkVector::Make(fDx, fDy);

ctx.ctm().mapVectors(&offsetVec, 1);

« no previous file with comments | « src/effects/SkColorMatrixFilter.cpp ('k') | src/effects/SkLayerDrawLooper.cpp » ('j') | no next file with comments »