gm/emboss.cpp - Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/emboss.cpp

Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/emboss.cpp

diff --git a/gm/emboss.cpp b/gm/emboss.cpp

index 20d3c918909e1faa12cddd57210703ba1fce6a84..5773577389ef7d5c25cc0bd1e63ebe9ea752547b 100644

--- a/gm/emboss.cpp

+++ b/gm/emboss.cpp

@@ -49,7 +49,7 @@

// this combination of emboss+colorfilter used to crash -- so we exercise it to

// confirm that we have a fix.

- paint.setColorFilter(SkColorFilter::CreateModeFilter(0xFFFF0000, SkXfermode::kSrcATop_Mode))->unref();

+ paint.setColorFilter(SkColorFilter::MakeModeFilter(0xFFFF0000, SkXfermode::kSrcATop_Mode));

canvas->translate(bm.width() + SkIntToScalar(10), 0);

canvas->drawBitmap(bm, 10, 10, &paint);

}

« no previous file with comments | « gm/dropshadowimagefilter.cpp ('k') | gm/fadefilter.cpp » ('j') | no next file with comments »