tests/PaintTest.cpp - Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PaintTest.cpp

Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/PaintTest.cpp

diff --git a/tests/PaintTest.cpp b/tests/PaintTest.cpp

index a58bd864ece75c165d8fe0ff58b3cdcc08d14a68..0e92e65ba3ec500a16e4907cbfd2ccba88dad4cb 100644

--- a/tests/PaintTest.cpp

+++ b/tests/PaintTest.cpp

@@ -360,11 +360,11 @@

SkColorMatrix cm;

cm.setIdentity(); // does not change alpha

- paint.setColorFilter(SkColorMatrixFilter::Create(cm))->unref();

+ paint.setColorFilter(SkColorFilter::MakeMatrixFilterRowMajor255(cm.fMat));

REPORTER_ASSERT(r, paint.nothingToDraw());

cm.postTranslate(0, 0, 0, 1); // wacks alpha

- paint.setColorFilter(SkColorMatrixFilter::Create(cm))->unref();

+ paint.setColorFilter(SkColorFilter::MakeMatrixFilterRowMajor255(cm.fMat));

REPORTER_ASSERT(r, !paint.nothingToDraw());

}

« no previous file with comments | « tests/ImageFilterTest.cpp ('k') | tests/PictureTest.cpp » ('j') | no next file with comments »