tests/GpuColorFilterTest.cpp - Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/GpuColorFilterTest.cpp

Issue 1827433002: Reland of [2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/GpuColorFilterTest.cpp

diff --git a/tests/GpuColorFilterTest.cpp b/tests/GpuColorFilterTest.cpp

index 830c7dfff3028f987dd8ea10e6ff0b4fed796579..714555a6260a890556d3844e50670b37bc8d13ad 100644

--- a/tests/GpuColorFilterTest.cpp

+++ b/tests/GpuColorFilterTest.cpp

@@ -99,8 +99,7 @@

GrPaint paint;

for (size_t i = 0; i < SK_ARRAY_COUNT(filterTests); ++i) {

const GetConstantComponentTestCase& test = filterTests[i];

- SkAutoTUnref<SkColorFilter> cf(

- SkColorFilter::CreateModeFilter(test.filterColor, test.filterMode));

+ auto cf(SkColorFilter::MakeModeFilter(test.filterColor, test.filterMode));

SkAutoTUnref<const GrFragmentProcessor> fp( cf->asFragmentProcessor(context));

REPORTER_ASSERT(reporter, fp);

GrInvariantOutput inout(test.inputColor,

« no previous file with comments | « tests/ColorMatrixTest.cpp ('k') | tests/ImageFilterTest.cpp » ('j') | no next file with comments »