Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1827403002: Fix old debugger for sk_sp changes (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M debugger/SkDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M debugger/SkDebugger.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 9 months ago (2016-03-25 13:19:47 UTC) #4
djsollen
lgtm
4 years, 9 months ago (2016-03-25 13:44:35 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827403002/1
4 years, 9 months ago (2016-03-25 13:46:38 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 14:01:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827403002/1
4 years, 9 months ago (2016-03-25 14:03:40 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 14:04:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/587ea71a522cd05601b401d17ad207c01f0ee0d6

Powered by Google App Engine
This is Rietveld 408576698