Add another body function returning a V8 Extra ReadableStream to Response

third_party/WebKit/Source/modules/fetch/Body.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/Body.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8ArrayBuffer.h"
 #include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/dom/DOMTypedArray.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/fileapi/Blob.h"
 #include "core/frame/UseCounter.h"
+#include "core/streams/ReadableStreamController.h"
+#include "core/streams/ReadableStreamOperations.h"
+#include "core/streams/UnderlyingSourceBase.h"
 #include "modules/fetch/BodyStreamBuffer.h"
 #include "modules/fetch/FetchDataLoader.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"

[tyoshino (SeeGerritForStatus), 2016/04/04 09:21:30]

OwnPtr.h
WebDataConsumerHandle.h

[yhirano, 2016/04/04 09:28:20]

Done.

 
 namespace blink {
 
 namespace {
 
 class BodyConsumerBase : public GarbageCollectedFinalized<BodyConsumerBase>, public FetchDataLoader::Client {
     WTF_MAKE_NONCOPYABLE(BodyConsumerBase);
     USING_GARBAGE_COLLECTED_MIXIN(BodyConsumerBase);
 public:
     explicit BodyConsumerBase(ScriptPromiseResolver* resolver) : m_resolver(resolver) {}
@@ skipping 61 matching lines @@
         v8::Local<v8::String> inputString = v8String(isolate, string);
         v8::TryCatch trycatch(isolate);
         v8::Local<v8::Value> parsed;
         if (v8Call(v8::JSON::Parse(isolate, inputString), parsed, trycatch))
             resolver()->resolve(parsed);
         else
             resolver()->reject(trycatch.Exception());
     }
 };
 
+class UnderlyingSourceFromDataConsumerHandle final : public UnderlyingSourceBase, public WebDataConsumerHandle::Client {
+    EAGERLY_FINALIZE();
+    DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();

[tyoshino (SeeGerritForStatus), 2016/04/04 09:21:30]

Could you please point me to some doc by which I can quickly learn these macros?
There I couldn't find any doc about eager finalization.

[yhirano, 2016/04/04 09:28:20]

I don't know much about it either. I got an assertion error and the comments
suggested using this macro.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

+public:
+    UnderlyingSourceFromDataConsumerHandle(ScriptState* scriptState, PassOwnPtr<WebDataConsumerHandle> handle)
+        : UnderlyingSourceBase(scriptState)
+        , m_scriptState(scriptState)
+        , m_reader(handle->obtainReader(this))
+    {
+    }
+
+    ScriptPromise pull(ScriptState* scriptState) override
+    {
+        didGetReadable();
+        return ScriptPromise::castUndefined(scriptState);
+    }
+
+    ScriptPromise cancel(ScriptState* scriptState, ScriptValue reason) override
+    {
+        m_reader = nullptr;
+        return ScriptPromise::castUndefined(scriptState);
+    }
+
+    void didGetReadable() override
+    {
+        while (controller()->desiredSize() > 0) {
+            const auto kNone = WebDataConsumerHandle::FlagNone;

[tyoshino (SeeGerritForStatus), 2016/04/04 09:21:30]

kNone is used just once. how about just putting the RHS?

[yhirano, 2016/04/04 09:28:20]

Done.

+            size_t available;
+            const void* buffer = nullptr;
+            WebDataConsumerHandle::Result result = m_reader->beginRead(&buffer, kNone, &available);
+            if (result == WebDataConsumerHandle::Ok) {
+                RefPtr<ArrayBuffer> arrayBuffer = ArrayBuffer::create(available, 1);
+                memcpy(arrayBuffer->data(), buffer, available);
+                m_reader->endRead(available);
+                controller()->enqueue(DOMUint8Array::create(arrayBuffer.release(), 0, available));
+            } else if (result == WebDataConsumerHandle::ShouldWait) {
+                break;
+            } else if (result == WebDataConsumerHandle::Done) {
+                m_reader = nullptr;
+                controller()->close();
+                break;
+            } else {
+                m_reader = nullptr;
+                controller()->error(V8ThrowException::createTypeError(m_scriptState->isolate(), "Network error"));
+                break;
+            }
+        }
+    }
+
+private:
+    RefPtr<ScriptState> m_scriptState;
+    OwnPtr<WebDataConsumerHandle::Reader> m_reader;
+};
+
 } // namespace
 
 ScriptPromise Body::arrayBuffer(ScriptState* scriptState)
 {
     ScriptPromise promise = rejectInvalidConsumption(scriptState);
     if (!promise.isEmpty())
         return promise;
 
     // When the main thread sends a V8::TerminateExecution() signal to a worker
     // thread, any V8 API on the worker thread starts returning an empty
@@ skipping 81 matching lines @@
 {
     return bodyBuffer() ? bodyBuffer()->stream() : nullptr;
 }
 
 ReadableByteStream* Body::bodyWithUseCounter()
 {
     UseCounter::count(getExecutionContext(), UseCounter::FetchBodyStream);
     return body();
 }
 
+ScriptValue Body::v8ExtraStreamBody(ScriptState* scriptState)
+{
+    if (bodyUsed() || isBodyLocked() || !bodyBuffer())
+        return ScriptValue(scriptState, v8::Undefined(scriptState->isolate()));
+    OwnPtr<FetchDataConsumerHandle> handle = bodyBuffer()->releaseHandle(scriptState->getExecutionContext());
+    return ReadableStreamOperations::createReadableStream(scriptState,
+        new UnderlyingSourceFromDataConsumerHandle(scriptState, handle.release()),
+        ScriptValue(scriptState, v8::Undefined(scriptState->isolate())));
+}
+
 bool Body::bodyUsed()
 {
     return body() && body()->isDisturbed();
 }
 
 bool Body::isBodyLocked()
 {
     return body() && body()->isLocked();
 }
 
@@ skipping 17 matching lines @@
 ScriptPromise Body::rejectInvalidConsumption(ScriptState* scriptState)
 {
     if (m_opaque)
         return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "The body is opaque."));
     if (isBodyLocked() || bodyUsed())
         return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "Already read"));
     return ScriptPromise();
 }
 
 } // namespace blink