pubspec.yaml - Issue 1827353003: pkg/matcher: a few more strong-mode fixes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pubspec.yaml

Issue 1827353003: pkg/matcher: a few more strong-mode fixes (Closed) Base URL: https://github.com/dart-lang/matcher.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 name: matcher	1 name: matcher

2 version: 0.12.0+2	2 version: 0.12.1-dev
	nweiz 2016/03/28 18:56:15 This won't work, because test has a tight constrai This won't work, because test has a tight constraint on matcher. See https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9... kevmoo 2016/03/28 19:18:59 Suggestions? Should I just land this as +3? Show quoted text On 2016/03/28 18:56:15, nweiz wrote: > This won't work, because test has a tight constraint on matcher. See > https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9... Suggestions? Should I just land this as +3? nweiz 2016/03/28 20:44:53 No, just do the same thing we did in the code I li Show quoted text On 2016/03/28 19:18:59, kevmoo wrote: > On 2016/03/28 18:56:15, nweiz wrote: > > This won't work, because test has a tight constraint on matcher. See > > > https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9... > > Suggestions? Should I just land this as +3? No, just do the same thing we did in the code I linked. kevmoo 2016/03/28 21:11:23 PTAL Show quoted text On 2016/03/28 20:44:53, nweiz wrote: > On 2016/03/28 19:18:59, kevmoo wrote: > > On 2016/03/28 18:56:15, nweiz wrote: > > > This won't work, because test has a tight constraint on matcher. See > > > > > > https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9... > > > > Suggestions? Should I just land this as +3? > > No, just do the same thing we did in the code I linked. PTAL
3 author: Dart Team <misc@dartlang.org>	3 author: Dart Team <misc@dartlang.org>

4 description: Support for specifying test expectations	4 description: Support for specifying test expectations

5 homepage: https://github.com/dart-lang/matcher	5 homepage: https://github.com/dart-lang/matcher

6 environment:	6 environment:

7 sdk: '>=1.0.0 <2.0.0'	7 sdk: '>=1.0.0 <2.0.0'

8 dev_dependencies:	8 dev_dependencies:

9 test: '>=0.12.0 <0.13.0'	9 test: '>=0.12.0 <0.13.0'

OLD	NEW

« no previous file with comments | « no previous file | test/pretty_print_test.dart » ('j') | no next file with comments »