pkg/matcher: a few more strong-mode fixes

a few more strong-mode fixes

R=nweiz@google.com

Committed: https://github.com/dart-lang/matcher/commit/831729359e015e1795254d1fb42f7c4803720f03

[kevmoo, 2016-03-25 07:06:26]

kevmoo@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2016-03-28 18:56:15]

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.1-dev
This won't work, because test has a tight constraint on matcher. See
https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9...

[kevmoo, 2016-03-28 19:19:00]

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.1-dev
On 2016/03/28 18:56:15, nweiz wrote:
> This won't work, because test has a tight constraint on matcher. See
>
https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9...

Suggestions? Should I just land this as +3?

[nweiz, 2016-03-28 20:44:53]

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.1-dev
On 2016/03/28 19:18:59, kevmoo wrote:
> On 2016/03/28 18:56:15, nweiz wrote:
> > This won't work, because test has a tight constraint on matcher. See
> >
>
https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9...
> 
> Suggestions? Should I just land this as +3?

No, just do the same thing we did in the code I linked.

[kevmoo, 2016-03-28 21:11:23]

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1827353003/diff/1/pubspec.yaml#newcode2
pubspec.yaml:2: version: 0.12.1-dev
On 2016/03/28 20:44:53, nweiz wrote:
> On 2016/03/28 19:18:59, kevmoo wrote:
> > On 2016/03/28 18:56:15, nweiz wrote:
> > > This won't work, because test has a tight constraint on matcher. See
> > >
> >
>
https://github.com/dart-lang/matcher/blob/5d649bcda2663a47ed30d413367873ff2f9...
> > 
> > Suggestions? Should I just land this as +3?
> 
> No, just do the same thing we did in the code I linked.

PTAL

[nweiz, 2016-03-28 21:12:39]

lgtm

[kevmoo, 2016-03-28 21:13:25]

Description was changed from

==========
a few more strong-mode fixes
==========

to

==========
a few more strong-mode fixes

R=nweiz@google.com

Committed:
https://github.com/dart-lang/matcher/commit/831729359e015e1795254d1fb42f7c480...
==========

[kevmoo, 2016-03-28 21:13:27]

Committed patchset #2 (id:20001) manually as
831729359e015e1795254d1fb42f7c4803720f03 (presubmit successful).