Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1827343003: Cleanup some extern method declarations. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup some extern method declarations. This CL removes _FPDFAPI_GetInternalFontData which is not implemented, FWL_PostMessageToMainRoop which has no body and the PostMessage which was the only caller. FWL_ShowCaret is moved to the only place where it's used. BUG=pdfium:112 Committed: https://pdfium.googlesource.com/pdfium/+/d7682aad8fc488e3e99c3e0de4bd13155deb7ce4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -41 lines) Patch
M core/fxge/ge/fx_ge_font.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 2 chunks +26 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/fwl/core/ifwl_notedriver.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.cpp View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-25 02:56:54 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-25 15:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827343003/1
4 years, 9 months ago (2016-03-25 15:54:19 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 15:54:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d7682aad8fc488e3e99c3e0de4bd13155deb...

Powered by Google App Engine
This is Rietveld 408576698