Issue 182733014: RenderLayerScrollableArea::updateResizerStyle shouldn't do work if there's no resizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182733014: RenderLayerScrollableArea::updateResizerStyle shouldn't do work if there's no resizer (Closed)

Created:
6 years, 9 months ago by abarth-chromium

Modified:
6 years, 9 months ago

Reviewers:
esprehn

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

RenderLayerScrollableArea::updateResizerStyle shouldn't do work if there's no resizer In profiling updateStyle on Silk's toggle_drawer test case, we saw some time being spent updating the style of the resizer, which is wasted work because there is no resizer. This CL teaches the code not to do work if there's no resizer. R=esprehn@chromium.org BUG=335703 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168555

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
		Source/core/rendering/RenderLayerScrollableArea.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/182733014/1

6 years, 9 months ago (2014-03-05 23:54:24 UTC) #5

abarth-chromium

6 years, 9 months ago (2014-03-06 02:03:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r168555 (presubmit successful).

Expand Messages | Collapse Messages