Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 182733009: [AudioPlayer] Don't start a playback automatically when reopening (Closed)

Created:
6 years, 9 months ago by yoshiki
Modified:
6 years, 8 months ago
Reviewers:
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[AudioPlayer] Don't start a playback automatically when reopening This patch is a reland of r254749, fixing a way to set the 'playing' attribute. BUG=chrome-os-partner:26171 TEST=manually TBR=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M chrome/browser/resources/file_manager/audio_player/elements/audio_player.js View 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/resources/file_manager/audio_player/js/audio_player.js View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/background/js/background.js View 8 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 9 months ago (2014-03-07 00:18:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/182733009/80001
6 years, 9 months ago (2014-03-07 00:25:43 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:14:24 UTC) #3
Message was sent while issue was closed.
Change committed as 255561

Powered by Google App Engine
This is Rietveld 408576698