Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: tools/skpinfo.cpp

Issue 182733008: Switch the factory chunk in the skps to storing its size in bytes (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Added comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/utils/SkMD5.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkCommandLineFlags.h" 8 #include "SkCommandLineFlags.h"
9 #include "SkPicture.h" 9 #include "SkPicture.h"
10 #include "SkPicturePlayback.h" 10 #include "SkPicturePlayback.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // chunks are encountered. 96 // chunks are encountered.
97 switch (tag) { 97 switch (tag) {
98 case SK_PICT_READER_TAG: 98 case SK_PICT_READER_TAG:
99 if (FLAGS_tags && !FLAGS_quiet) { 99 if (FLAGS_tags && !FLAGS_quiet) {
100 SkDebugf("SK_PICT_READER_TAG %d\n", chunkSize); 100 SkDebugf("SK_PICT_READER_TAG %d\n", chunkSize);
101 } 101 }
102 break; 102 break;
103 case SK_PICT_FACTORY_TAG: 103 case SK_PICT_FACTORY_TAG:
104 if (FLAGS_tags && !FLAGS_quiet) { 104 if (FLAGS_tags && !FLAGS_quiet) {
105 SkDebugf("SK_PICT_FACTORY_TAG %d\n", chunkSize); 105 SkDebugf("SK_PICT_FACTORY_TAG %d\n", chunkSize);
106 SkDebugf("Exiting early due to format limitations\n");
107 } 106 }
108 return kSuccess; // TODO: need to store size in bytes 107 // Remove this code when v21 and below are no longer supported
108 #ifndef DISABLE_V21_COMPATIBILITY_CODE
109 if (info.fVersion < 22) {
110 if (!FLAGS_quiet) {
111 SkDebugf("Exiting early due to format limitations\n");
112 }
113 return kSuccess; // TODO: need to store size in bytes
114 }
115 #endif
109 break; 116 break;
110 case SK_PICT_TYPEFACE_TAG: 117 case SK_PICT_TYPEFACE_TAG:
111 if (FLAGS_tags && !FLAGS_quiet) { 118 if (FLAGS_tags && !FLAGS_quiet) {
112 SkDebugf("SK_PICT_TYPEFACE_TAG %d\n", chunkSize); 119 SkDebugf("SK_PICT_TYPEFACE_TAG %d\n", chunkSize);
113 SkDebugf("Exiting early due to format limitations\n"); 120 SkDebugf("Exiting early due to format limitations\n");
114 } 121 }
115 return kSuccess; // TODO: need to store size in bytes 122 return kSuccess; // TODO: need to store size in bytes
116 break; 123 break;
117 case SK_PICT_PICTURE_TAG: 124 case SK_PICT_PICTURE_TAG:
118 if (FLAGS_tags && !FLAGS_quiet) { 125 if (FLAGS_tags && !FLAGS_quiet) {
(...skipping 23 matching lines...) Expand all
142 } 149 }
143 150
144 return kSuccess; 151 return kSuccess;
145 } 152 }
146 153
147 #if !defined SK_BUILD_FOR_IOS 154 #if !defined SK_BUILD_FOR_IOS
148 int main(int argc, char * const argv[]) { 155 int main(int argc, char * const argv[]) {
149 return tool_main(argc, (char**) argv); 156 return tool_main(argc, (char**) argv);
150 } 157 }
151 #endif 158 #endif
OLDNEW
« no previous file with comments | « src/utils/SkMD5.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698