Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 182733006: Add UseCounter value for HTMLAppletElement and UTF16AsWebExposedEncoding (Closed)

Created:
6 years, 9 months ago by mathiasb
Modified:
5 years, 9 months ago
Reviewers:
Ilya Sherman, jsbell
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add UseCounter value for HTMLAppletElement and UTF16AsWebExposedEncoding Corresponds to https://codereview.chromium.org/183893021. R=jsbell@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mathiasb
Note that I had to add `HTMLAppletElement` too, as it was still missing.
6 years, 9 months ago (2014-03-04 15:46:01 UTC) #1
jsbell
I'm not an OWNER and can't speak to whether this will give enough data. It'd ...
6 years, 9 months ago (2014-03-04 17:01:19 UTC) #2
mathiasb
On 2014/03/04 17:01:19, jsbell wrote: > It'd also be nice to land the histogram in ...
6 years, 9 months ago (2014-03-04 17:09:26 UTC) #3
jsbell
On 2014/03/04 17:09:26, mathiasb wrote: > On 2014/03/04 17:01:19, jsbell wrote: > > It'd also ...
6 years, 9 months ago (2014-03-04 17:14:40 UTC) #4
Ilya Sherman
LGTM
6 years, 9 months ago (2014-03-04 22:46:31 UTC) #5
jsbell
Is there still desire to pursue this (given that we have other ways go gather ...
6 years, 8 months ago (2014-04-11 15:56:59 UTC) #6
Ilya Sherman
If you've already committed the C++ code that emits to this histogram, then you should ...
6 years, 8 months ago (2014-04-11 22:56:45 UTC) #7
mathiasb
On 2014/04/11 15:56:59, jsbell wrote: > Is there still desire to pursue this (given that ...
6 years, 8 months ago (2014-04-14 08:33:10 UTC) #8
jsbell
5 years, 9 months ago (2015-03-13 20:51:37 UTC) #9
"other means" are mentioned in comment #8 over in
https://codereview.chromium.org/183893021/ (with data circa 2013) - we can use
the crawl stats from a (*cough*) large search engine. This misses out on
intranets, but then so may UMA stats.

Gonna close this out.

Powered by Google App Engine
This is Rietveld 408576698