Reland of Add bisect config validation.

Reland of Add bisect config validation. (patchset #1 id:1 of https://codereview.chromium.org/1831843002/ )

Reason for revert:
Reland bisect config validation with bug fix

Original issue's description:
> Revert of Add bisect config validation. (patchset #4 id:60001 of https://codereview.chromium.org/1782333002/ )
> 
> Reason for revert:
> https://bugs.chromium.org/p/chromium/issues/detail?id=597655
> 
> Original issue's description:
> > Add bisect config validation.
> > 
> > BUG=485672
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299450
> 
> TBR=chrisphan@chromium.org,robertocn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=485672
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299470

TBR=chrisphan@chromium.org,robertocn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485672
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299570

[qyearsley, 2016-03-24 22:44:13]

Created Reland of Add bisect config validation.

[chrisphan, 2016-03-24 22:54:21]

lgtm

What was the bug fix?

[qyearsley, 2016-03-24 23:06:52]

On 2016/03/24 at 22:54:21, chrisphan wrote:
> lgtm
> 
> What was the bug fix?

Actually, there's no bug fix yet so for now this should be not lgtm -- I plan to
add the bug fix as a patch to this CL.

[qyearsley, 2016-03-24 23:20:54]

https://codereview.chromium.org/1827313002/diff/290001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/auto_bisect/config_validation.py (right):

https://codereview.chromium.org/1827313002/diff/290001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/auto_bisect/config_validation.py:52: if
config.get(key) is None:
This is the line that I changed for this patch that's different from before --
if the field is optional (as "builder_host" and "builder_port" are), then None
is always an acceptable value.

However, if the value is required, then None is never acceptable.

Does that seem reasonable?

[chrisphan, 2016-03-24 23:24:58]

https://codereview.chromium.org/1827313002/diff/290001/scripts/slave/recipe_m...
File scripts/slave/recipe_modules/auto_bisect/config_validation.py (right):

https://codereview.chromium.org/1827313002/diff/290001/scripts/slave/recipe_m...
scripts/slave/recipe_modules/auto_bisect/config_validation.py:52: if
config.get(key) is None:
On 2016/03/24 23:20:54, qyearsley wrote:
> This is the line that I changed for this patch that's different from before --
> if the field is optional (as "builder_host" and "builder_port" are), then None
> is always an acceptable value.
> 
> However, if the value is required, then None is never acceptable.
> 
> Does that seem reasonable?

Yup.

[qyearsley, 2016-03-24 23:25:16]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 23:25:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827313002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827313002/290001

[commit-bot: I haz the power, 2016-03-24 23:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 23:25:24]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-03-25 21:27:30]

qyearsley@chromium.org changed reviewers:
+ prasadv@chromium.org

[qyearsley, 2016-03-25 21:27:43]

On 2016/03/24 at 23:25:24, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

Roberto, Prasad, does this fix look OK to land?

[qyearsley, 2016-03-29 15:57:58]

On 2016/03/25 at 21:27:43, qyearsley wrote:
> On 2016/03/24 at 23:25:24, commit-bot wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> Roberto, Prasad, does this fix look OK to land?

Ping

[prasadv, 2016-03-30 17:44:05]

lgtm

[qyearsley, 2016-03-30 17:45:26]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-03-30 17:45:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrisphan@chromium.org
Link to the patchset: https://codereview.chromium.org/1827313002/#ps310001
(title: "Rebased")

[commit-bot: I haz the power, 2016-03-30 17:45:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827313002/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827313002/310001

[commit-bot: I haz the power, 2016-03-30 17:45:46]

Description was changed from

==========
Reland of Add bisect config validation. (patchset #1 id:1 of
https://codereview.chromium.org/1831843002/ )

Reason for revert:
Reland bisect config validation with bug fix

Original issue's description:
> Revert of Add bisect config validation. (patchset #4 id:60001 of
https://codereview.chromium.org/1782333002/ )
> 
> Reason for revert:
> https://bugs.chromium.org/p/chromium/issues/detail?id=597655
> 
> Original issue's description:
> > Add bisect config validation.
> > 
> > BUG=485672
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299450
> 
> TBR=chrisphan@chromium.org,robertocn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=485672
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299470

TBR=chrisphan@chromium.org,robertocn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485672
==========

to

==========
Reland of Add bisect config validation. (patchset #1 id:1 of
https://codereview.chromium.org/1831843002/ )

Reason for revert:
Reland bisect config validation with bug fix

Original issue's description:
> Revert of Add bisect config validation. (patchset #4 id:60001 of
https://codereview.chromium.org/1782333002/ )
> 
> Reason for revert:
> https://bugs.chromium.org/p/chromium/issues/detail?id=597655
> 
> Original issue's description:
> > Add bisect config validation.
> > 
> > BUG=485672
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299450
> 
> TBR=chrisphan@chromium.org,robertocn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=485672
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299470

TBR=chrisphan@chromium.org,robertocn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485672

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299570
==========

[commit-bot: I haz the power, 2016-03-30 17:45:47]

Committed patchset #3 (id:310001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299570