Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 18273002: Add PPAPI style enums to V2 IDL parser (Closed)

Created:
7 years, 5 months ago by noelallen1
Modified:
7 years, 5 months ago
Reviewers:
nfullagar1
CC:
chromium-reviews
Visibility:
Public.

Description

Adds the ability to process identifier or identifier = ConstValue and removes string from Enums for Pepper IDL. BUG=224150 TEST=PRESUBMIT or ./run_tests.py R=nfullagar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209454

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -31 lines) Patch
M tools/idl_parser/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/idl_parser/idl_ppapi_parser.py View 1 chunk +241 lines, -0 lines 0 comments Download
A + tools/idl_parser/test_parser/enum_ppapi.idl View 1 2 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
ptal
7 years, 5 months ago (2013-06-29 20:09:15 UTC) #1
nfullagar1
https://codereview.chromium.org/18273002/diff/1/tools/idl_parser/test_parser/enum_ppapi.idl File tools/idl_parser/test_parser/enum_ppapi.idl (right): https://codereview.chromium.org/18273002/diff/1/tools/idl_parser/test_parser/enum_ppapi.idl#newcode115 tools/idl_parser/test_parser/enum_ppapi.idl:115: noodles = 0x1 << 0x2, what is expected outcome ...
7 years, 5 months ago (2013-07-01 17:22:13 UTC) #2
noelallen1
https://codereview.chromium.org/18273002/diff/1/tools/idl_parser/test_parser/enum_ppapi.idl File tools/idl_parser/test_parser/enum_ppapi.idl (right): https://codereview.chromium.org/18273002/diff/1/tools/idl_parser/test_parser/enum_ppapi.idl#newcode115 tools/idl_parser/test_parser/enum_ppapi.idl:115: noodles = 0x1 << 0x2, On 2013/07/01 17:22:13, nfullagar1 ...
7 years, 5 months ago (2013-07-01 17:46:06 UTC) #3
nfullagar1
thx for adding the test, lgtm
7 years, 5 months ago (2013-07-01 17:53:46 UTC) #4
noelallen1
7 years, 5 months ago (2013-07-01 17:56:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r209454 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698