Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1827293002: Use AbstractSingleUnitTest, so MockSdk in resynthesize tests. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use AbstractSingleUnitTest, so MockSdk in resynthesize tests. When we prelink AST based summaries we need to be able to read referenced sources. So, mock SDK element model is not enough. Plus it was quite a lot of work in the past to fix this mock element model to provide all the data we expect from it during summarizing. One of the negative effects is increasing analysis time from 26 to 34 seconds. We can try to implement sharing SDK between tests later. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/01b80afb835f10ec6df58e6625602849abe54a80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -71 lines) Patch
M pkg/analyzer/test/src/abstract_single_unit.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 24 chunks +96 lines, -70 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-24 22:08:03 UTC) #1
Paul Berry
lgtm
4 years, 9 months ago (2016-03-24 22:27:34 UTC) #2
scheglov
4 years, 9 months ago (2016-03-24 23:59:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01b80afb835f10ec6df58e6625602849abe54a80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698