Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1827243003: Allow values to be returned from implicitly typed setters (Closed)

Created:
4 years, 9 months ago by Leaf
Modified:
4 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow values to be returned from implicitly typed function bodied setters. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/77ee0546782692080cfdcd7e205a4e317e424ee8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Leaf
4 years, 9 months ago (2016-03-25 00:54:05 UTC) #3
Bob Nystrom
LGTM!
4 years, 9 months ago (2016-03-25 01:08:43 UTC) #4
Leaf
4 years, 9 months ago (2016-03-25 16:56:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77ee0546782692080cfdcd7e205a4e317e424ee8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698