Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1827223002:
url bar selects all on focus (Closed)
|
Created:
4 years, 9 months ago by shaktisahu Modified:
4 years, 9 months ago CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionurl bar selects all on focus
BUG=597708
Committed: https://crrev.com/b510b46d889645e794b6c17d7b4df6f9cbdb2d9e
Cr-Commit-Position: refs/heads/master@{#383177}
Patch Set 1 #
Messages
Total messages: 20 (8 generated)
shaktisahu@chromium.org changed reviewers: + haibinlu@chromium.org, kmarshall@chromium.org, nyquist@chromium.org
kmarshall@chromium.org: Please review changes in nyquist@chromium.org: Please review changes in haibinlu@chromium.org: Please review changes in
is this ready to review?
On 2016/03/24 20:21:50, haibinlu wrote: > is this ready to review? Yes
lgtm
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827223002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827223002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
khushalsagar@chromium.org changed reviewers: + khushalsagar@chromium.org
lgtm.
The CQ bit was checked by shaktisahu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827223002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== url bar selects all on focus BUG=597708 ========== to ========== url bar selects all on focus BUG=597708 Committed: https://crrev.com/b510b46d889645e794b6c17d7b4df6f9cbdb2d9e Cr-Commit-Position: refs/heads/master@{#383177} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b510b46d889645e794b6c17d7b4df6f9cbdb2d9e Cr-Commit-Position: refs/heads/master@{#383177} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
