Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1827163002: build: enable some dependencies in mac (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: enable some dependencies in mac We have these targets in gn now. BUG=None R=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg Committed: https://crrev.com/9685d6f9768a7da085d401d669adc86012cfdfc7 Cr-Commit-Position: refs/heads/master@{#383262}

Patch Set 1 #

Patch Set 2 : these lines are gn labels - just remove it - they have been ported already #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/gn_migration.gypi View 1 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
tfarina
Fired the trybots, will see what they say. PTAL. https://codereview.chromium.org/1827163002/diff/20001/build/gn_migration.gypi File build/gn_migration.gypi (left): https://codereview.chromium.org/1827163002/diff/20001/build/gn_migration.gypi#oldcode486 build/gn_migration.gypi:486: ...
4 years, 9 months ago (2016-03-24 20:42:40 UTC) #1
Dirk Pranke
lgtm. I added the dbg gn bot as well to make sure that works, too.
4 years, 9 months ago (2016-03-24 21:29:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827163002/20001
4 years, 9 months ago (2016-03-25 07:15:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-25 07:43:47 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 07:44:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9685d6f9768a7da085d401d669adc86012cfdfc7
Cr-Commit-Position: refs/heads/master@{#383262}

Powered by Google App Engine
This is Rietveld 408576698