Add GLFW support for GrGLCreateNativeInterface

Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1827153003
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/7fb19bc229ba4e7482ff7c0fd24bd2fcb0093b8b

[abarth-chromium, 2016-03-24 22:54:02]

Description was changed from

==========
Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
==========

to

==========
Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[abarth, 2016-03-24 22:55:33]

abarth@google.com changed reviewers:
+ abarth@google.com, bsalomon@google.com, reed@google.com

[abarth, 2016-03-24 22:55:34]

Not sure if you folks want this file, but conceptually it belongs here in the
source tree.

[bsalomon, 2016-03-28 16:55:58]

On 2016/03/24 22:55:34, abarth wrote:
> Not sure if you folks want this file, but conceptually it belongs here in the
> source tree.


If it's useful to someone, happy to have it. Maybe it should be it's own factory
rather than a impl of GrCLCreateNativeInterface? It's possible to construct a
GrContext for any arbitrary GrGLInterface using:


GrContext::Create(kOpenGL_GrBackend,
reinterpret_cast<GrBackendContext>(grglinterfaceptr)).

[abarth, 2016-03-28 17:01:50]

On 2016/03/28 at 16:55:58, bsalomon wrote:
> On 2016/03/24 22:55:34, abarth wrote:
> > Not sure if you folks want this file, but conceptually it belongs here in
the
> > source tree.
> 
> If it's useful to someone, happy to have it. Maybe it should be it's own
factory rather than a impl of GrCLCreateNativeInterface?

That's up to you.  In our case, we have a build flag for GLFW because we need to
adjust a bunch of our other definitions to use glfw rather than glx types.  It's
easier then to just link in GrGLCreateNativeInterface_glfw.cpp rather than
GrGLCreateNativeInterface_glx.cpp.

[bsalomon, 2016-03-28 17:03:08]

On 2016/03/28 17:01:50, abarth wrote:
> On 2016/03/28 at 16:55:58, bsalomon wrote:
> > On 2016/03/24 22:55:34, abarth wrote:
> > > Not sure if you folks want this file, but conceptually it belongs here in
> the
> > > source tree.
> > 
> > If it's useful to someone, happy to have it. Maybe it should be it's own
> factory rather than a impl of GrCLCreateNativeInterface?
> 
> That's up to you.  In our case, we have a build flag for GLFW because we need
to
> adjust a bunch of our other definitions to use glfw rather than glx types. 
It's
> easier then to just link in GrGLCreateNativeInterface_glfw.cpp rather than
> GrGLCreateNativeInterface_glx.cpp.

Gotcha, sgtm, lgtm.

[abarth, 2016-03-28 17:33:39]

The CQ bit was checked by abarth@google.com

[commit-bot: I haz the power, 2016-03-28 17:33:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827153003/1

[commit-bot: I haz the power, 2016-03-28 17:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 17:43:02]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[abarth-chromium, 2016-03-28 18:19:05]

Description was changed from

==========
Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[abarth, 2016-03-28 18:19:16]

The CQ bit was checked by abarth@google.com

[abarth, 2016-03-28 18:19:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1827153003/#ps20001
(title: "Fix cmake build")

[commit-bot: I haz the power, 2016-03-28 18:19:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827153003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827153003/20001

[commit-bot: I haz the power, 2016-03-28 18:34:29]

Description was changed from

==========
Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Add GLFW support for GrGLCreateNativeInterface

This file lets us use Skia's GPU backend with GLFW.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/7fb19bc229ba4e7482ff7c0fd24bd2fcb0093b8b
==========

[commit-bot: I haz the power, 2016-03-28 18:34:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7fb19bc229ba4e7482ff7c0fd24bd2fcb0093b8b