Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1827153003: Add GLFW support for GrGLCreateNativeInterface (Closed)

Created:
4 years, 9 months ago by abarth-chromium
Modified:
4 years, 8 months ago
Reviewers:
abarth, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GLFW support for GrGLCreateNativeInterface This file lets us use Skia's GPU backend with GLFW. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1827153003 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/7fb19bc229ba4e7482ff7c0fd24bd2fcb0093b8b

Patch Set 1 #

Patch Set 2 : Fix cmake build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M cmake/CMakeLists.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + src/gpu/gl/glfw/GrGLCreateNativeInterface_glfw.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
abarth
Not sure if you folks want this file, but conceptually it belongs here in the ...
4 years, 9 months ago (2016-03-24 22:55:34 UTC) #3
bsalomon
On 2016/03/24 22:55:34, abarth wrote: > Not sure if you folks want this file, but ...
4 years, 8 months ago (2016-03-28 16:55:58 UTC) #4
abarth
On 2016/03/28 at 16:55:58, bsalomon wrote: > On 2016/03/24 22:55:34, abarth wrote: > > Not ...
4 years, 8 months ago (2016-03-28 17:01:50 UTC) #5
bsalomon
On 2016/03/28 17:01:50, abarth wrote: > On 2016/03/28 at 16:55:58, bsalomon wrote: > > On ...
4 years, 8 months ago (2016-03-28 17:03:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827153003/1
4 years, 8 months ago (2016-03-28 17:33:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot/builds/433)
4 years, 8 months ago (2016-03-28 17:43:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827153003/20001
4 years, 8 months ago (2016-03-28 18:19:19 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 18:34:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7fb19bc229ba4e7482ff7c0fd24bd2fcb0093b8b

Powered by Google App Engine
This is Rietveld 408576698