Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1827143002: Revert of [Interpreter] Remove separate Ignition snapshot. (Closed)

Created:
4 years, 9 months ago by rmcilroy
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Remove separate Ignition snapshot. (patchset #2 id:20001 of https://codereview.chromium.org/1833643002/ ) Reason for revert: Makes nosnap bots timeout due to having to rebuild bytecode handlers. Original issue's description: > [Interpreter] Remove separate Ignition snapshot. > > Removes the seperate Ignition snapshot and build the Ignition bytecode > handlers in the default snapshot. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/1798f3fe84faff32ba44e09f6aed79245dd98d80 > Cr-Commit-Position: refs/heads/master@{#35058} TBR=machenbach@google.com,yangguo@chromium.org,mstarzinger@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/bdf953b5cca0860bb11b8699f94770414ca19266 Cr-Commit-Position: refs/heads/master@{#35059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -22 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/isolate.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/standalone.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/toolchain.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M src/base.isolate View 1 chunk +7 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/startup-data-util.cc View 2 chunks +4 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/interpreter/interpreter-tester.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 6 chunks +84 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmcilroy
Created Revert of [Interpreter] Remove separate Ignition snapshot.
4 years, 9 months ago (2016-03-24 17:11:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827143002/1
4 years, 9 months ago (2016-03-24 17:12:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 17:12:25 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 17:13:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdf953b5cca0860bb11b8699f94770414ca19266
Cr-Commit-Position: refs/heads/master@{#35059}

Powered by Google App Engine
This is Rietveld 408576698