Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 182713005: Remove frame ID from DidCommitProvisionalLoad. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix John's comments and signin test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.h
diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h
index a33f5bccd7a4c24737b40c882a1525fd3c2994ea..91fcd6e395539419f7fc9d0676a10ef9ee2d46fa 100644
--- a/content/browser/frame_host/navigation_controller_impl.h
+++ b/content/browser/frame_host/navigation_controller_impl.h
@@ -134,10 +134,8 @@ class CONTENT_EXPORT NavigationControllerImpl
//
// In the case that nothing has changed, the details structure is undefined
// and it will return false.
- //
- // TODO(creis): Change RenderViewHost to RenderFrameHost.
bool RendererDidNavigate(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
LoadCommittedDetails* details);
@@ -235,7 +233,7 @@ class CONTENT_EXPORT NavigationControllerImpl
// Classifies the given renderer navigation (see the NavigationType enum).
NavigationType ClassifyNavigation(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params) const;
// Causes the controller to load the specified entry. The function assumes
@@ -255,27 +253,25 @@ class CONTENT_EXPORT NavigationControllerImpl
// The functions taking |did_replace_entry| will fill into the given variable
// whether the last entry has been replaced or not.
// See LoadCommittedDetails.did_replace_entry.
- //
- // TODO(creis): Change RenderViewHost to RenderFrameHost.
void RendererDidNavigateToNewPage(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
bool replace_entry);
void RendererDidNavigateToExistingPage(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
void RendererDidNavigateToSamePage(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
void RendererDidNavigateInPage(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
bool* did_replace_entry);
void RendererDidNavigateNewSubframe(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
bool RendererDidNavigateAutoSubframe(
- RenderViewHost* rvh,
+ RenderFrameHost* rfh,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
// Helper function for code shared between Reload() and ReloadIgnoringCache().

Powered by Google App Engine
This is Rietveld 408576698