Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182713002: Import Blink layout tests for Promises. (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 9 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Import Blink layout tests for Promises. Import Blink layout tests for Promises. We omitted some tests (for example workers tests). We fixed some wrong test expectations. BUG=347095 LOG=N R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1180 lines, -367 lines) Patch
A + test/webkit/fast/js/Promise-already-rejected.js View 2 chunks +16 lines, -11 lines 0 comments Download
A test/webkit/fast/js/Promise-already-rejected-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-already-resolved.js View 2 chunks +18 lines, -11 lines 0 comments Download
A test/webkit/fast/js/Promise-already-resolved-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-catch.js View 2 chunks +37 lines, -46 lines 0 comments Download
A test/webkit/fast/js/Promise-catch-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-chained-then.js View 1 chunk +72 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-chained-then-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-exception.js View 2 chunks +18 lines, -11 lines 0 comments Download
A test/webkit/fast/js/Promise-exception-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-init.js View 1 chunk +70 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-init-callback-receiver.js View 2 chunks +8 lines, -12 lines 0 comments Download
A test/webkit/fast/js/Promise-init-callback-receiver-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-init-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-onFulfilled-deep.js View 2 chunks +15 lines, -17 lines 0 comments Download
A test/webkit/fast/js/Promise-onFulfilled-deep-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-onRejected-deep.js View 2 chunks +15 lines, -25 lines 0 comments Download
A test/webkit/fast/js/Promise-onRejected-deep-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-reject.js View 2 chunks +27 lines, -29 lines 0 comments Download
A test/webkit/fast/js/Promise-reject-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve.js View 2 chunks +17 lines, -11 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve-chain.js View 2 chunks +33 lines, -32 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-chain-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve-state.js View 2 chunks +27 lines, -29 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-state-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve-with-itself.js View 2 chunks +15 lines, -14 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-with-itself-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve-with-then-exception.js View 2 chunks +18 lines, -15 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-with-then-exception-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve-with-then-fulfill.js View 2 chunks +26 lines, -15 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-with-then-fulfill-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-resolve-with-then-reject.js View 2 chunks +26 lines, -15 lines 0 comments Download
A test/webkit/fast/js/Promise-resolve-with-then-reject-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-simple.js View 2 chunks +22 lines, -13 lines 0 comments Download
A test/webkit/fast/js/Promise-simple-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-static-all.js View 1 chunk +117 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-static-all-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-static-cast.js View 2 chunks +30 lines, -10 lines 0 comments Download
A test/webkit/fast/js/Promise-static-cast-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-static-race.js View 1 chunk +108 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-static-race-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-static-reject.js View 2 chunks +13 lines, -11 lines 0 comments Download
A test/webkit/fast/js/Promise-static-reject-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-static-resolve.js View 2 chunks +17 lines, -10 lines 0 comments Download
A test/webkit/fast/js/Promise-static-resolve-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-then.js View 2 chunks +44 lines, -7 lines 0 comments Download
A + test/webkit/fast/js/Promise-then-callback-receiver.js View 2 chunks +23 lines, -11 lines 0 comments Download
A test/webkit/fast/js/Promise-then-callback-receiver-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A test/webkit/fast/js/Promise-then-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A + test/webkit/fast/js/Promise-then-without-callbacks.js View 2 chunks +11 lines, -12 lines 0 comments Download
A test/webkit/fast/js/Promise-then-without-callbacks-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
Jochen, can you take a look at this CL?
6 years, 9 months ago (2014-02-27 07:27:57 UTC) #1
yhirano
Some tests fail with the current implementation. The following CLs address the failres. [1]: https://codereview.chromium.org/182613003/ ...
6 years, 9 months ago (2014-02-27 12:57:15 UTC) #2
jochen (gone - plz use gerrit)
Andreas should review this
6 years, 9 months ago (2014-02-27 14:16:07 UTC) #3
rossberg
LGTM I only looked at some, rubber-stamped the rest
6 years, 9 months ago (2014-02-28 16:26:29 UTC) #4
rossberg
6 years, 9 months ago (2014-03-10 12:31:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r19757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698