Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/functions_target.cc

Issue 1827103005: [GN] Add support for generating Xcode projects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve comment about "assert(product_type != "")" Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/create_bundle_target_generator.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions_target.cc
diff --git a/tools/gn/functions_target.cc b/tools/gn/functions_target.cc
index 7ec5a50dd2675d81102bf3f6500d39841231aa2f..cc863ac0ca1d852b18d32a8de377b4194a7f96f7 100644
--- a/tools/gn/functions_target.cc
+++ b/tools/gn/functions_target.cc
@@ -331,7 +331,8 @@ const char kCreateBundle_Help[] =
"Variables\n"
"\n"
" bundle_root_dir*, bundle_resources_dir*, bundle_executable_dir*,\n"
- " bundle_plugins_dir*, deps, data_deps, public_deps, visibility\n"
+ " bundle_plugins_dir*, deps, data_deps, public_deps, visibility,\n"
+ " product_type\n"
" * = required\n"
"\n"
"Example\n"
@@ -378,6 +379,7 @@ const char kCreateBundle_Help[] =
" }\n"
"\n"
" create_bundle(\"${app_name}.app\") {\n"
+ " product_type = \"com.apple.product-type.application\"\n"
" deps = [\n"
" \":${app_name}_bundle_executable\",\n"
" \":${app_name}_bundle_info_plist\",\n"
« no previous file with comments | « tools/gn/create_bundle_target_generator.cc ('k') | tools/gn/gn.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698