Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/gn/bundle_data.h

Issue 1827103005: [GN] Add support for generating Xcode projects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve comment about "assert(product_type != "")" Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/DEPS ('k') | tools/gn/command_gen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bundle_data.h
diff --git a/tools/gn/bundle_data.h b/tools/gn/bundle_data.h
index d74267455e642d10d39c95fb62a6a56932b82ec6..9a2ea0790841fbb9aa27d04a5cb762109dae04c7 100644
--- a/tools/gn/bundle_data.h
+++ b/tools/gn/bundle_data.h
@@ -98,6 +98,9 @@ class BundleData {
SourceDir& plugins_dir() { return plugins_dir_; }
const SourceDir& plugins_dir() const { return plugins_dir_; }
+ std::string& product_type() { return product_type_; }
+ const std::string& product_type() const { return product_type_; }
+
// Recursive collection of all bundle_data that the target depends on.
const UniqueTargets& bundle_deps() const { return bundle_deps_; }
@@ -112,6 +115,12 @@ class BundleData {
SourceDir resources_dir_;
SourceDir executable_dir_;
SourceDir plugins_dir_;
+
+ // This is the target type as known to Xcode. This is only used to generate
+ // the Xcode project file when using --ide=xcode.
+ std::string product_type_;
+
+ DISALLOW_COPY_AND_ASSIGN(BundleData);
};
#endif // TOOLS_GN_BUNDLE_DATA_H_
« no previous file with comments | « tools/gn/DEPS ('k') | tools/gn/command_gen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698