Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 18271012: Add expectations files covering new image files. (Closed)

Created:
7 years, 5 months ago by scroggo
Modified:
7 years, 5 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add expectations files covering new image files. New image files are in Google Storage, so add expectations for them. The ICO file is expected to fail, although there is a patch to fix that out for review (https://chromiumcodereview.appspot.com/18655007/) Unreviewed. Since we are currently ignoring failures in skimage, this should at most produce a warning, but I expect it to remove the current warning state. The razr expectation is copied from nexus-7, as razr is currently not working. Committed: https://code.google.com/p/skia/source/detail?r=9915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+912 lines, -0 lines) Patch
M expectations/skimage/base-android-galaxy-nexus.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-android-nexus-10.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-android-nexus-4.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-android-nexus-7.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-android-nexus-s.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-android-razr-i.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-android-xoom.json View 4 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-macmini.json View 3 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-macmini-10_8.json View 3 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-macmini-lion-float.json View 3 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-shuttle-win7-intel-angle.json View 3 chunks +60 lines, -0 lines 0 comments Download
M expectations/skimage/base-shuttle-win7-intel-directwrite.json View 3 chunks +60 lines, -0 lines 0 comments Download
M expectations/skimage/base-shuttle-win7-intel-float.json View 3 chunks +66 lines, -0 lines 0 comments Download
M expectations/skimage/base-shuttle_ubuntu12_ati5770.json View 3 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scroggo
7 years, 5 months ago (2013-07-08 23:17:34 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r9915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698