Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827083003: Address comments in the orignial CL (Closed)

Created:
4 years, 9 months ago by oshima
Modified:
4 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address comments in the orignial CL BUG=597274 TBR=stevenjb@chromium.org Committed: https://crrev.com/6d221f22e58f3706147d2c8d5cec7b9fd2b3566b Cr-Commit-Position: refs/heads/master@{#383190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M ash/display/display_layout_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/extended_mouse_warp_controller.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
oshima
I landed the CL without noticing my patch upload failed. Sorry about that.
4 years, 9 months ago (2016-03-24 22:22:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827083003/1
4 years, 9 months ago (2016-03-24 22:24:37 UTC) #4
stevenjb
lgtm
4 years, 9 months ago (2016-03-24 22:45:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827083003/1
4 years, 9 months ago (2016-03-24 22:46:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 23:41:49 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 23:42:55 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6d221f22e58f3706147d2c8d5cec7b9fd2b3566b
Cr-Commit-Position: refs/heads/master@{#383190}

Powered by Google App Engine
This is Rietveld 408576698