third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp - Issue 1827083002: Add spacingDisabled() check to ShapeResultSpacing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

Issue 1827083002: Add spacingDisabled() check to ShapeResultSpacing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

index 099382c1661e79c92c3b9ca25620078403e4375d..40f2d909d8a87f4b6c6c326ba7ba11e982aad2fe 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

@@ -24,6 +24,9 @@ ShapeResultSpacing::ShapeResultSpacing(const TextRun& run,

, m_isAfterExpansion(false)

, m_isVerticalOffset(fontDescription.isVerticalAnyUpright())

{

+ if (m_textRun.spacingDisabled())

eae 2016/03/24 16:37:47 This only applies to SVG, right?

fs 2016/03/24 16:42:59 Yepp: https://code.google.com/p/chromium/codesear

+ return;

if (!m_letterSpacing && !m_wordSpacing && !m_expansion)

return;

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »