Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1827063004: Blacklist giant (4k) wbmp from GPU bots. (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
Reviewers:
msarett, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : git status #

Total comments: 1

Patch Set 3 : git status #

Patch Set 4 : Only blacklist on the failing Mac bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -0 lines) Patch
M tools/dm_flags.json View 1 2 3 1 chunk +341 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Brian Osman
4 years, 9 months ago (2016-03-24 15:54:13 UTC) #3
msarett
lgtm https://codereview.chromium.org/1827063004/diff/20001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/1827063004/diff/20001/tools/dm_flags.py#newcode190 tools/dm_flags.py:190: # Blacklist RAW images (and a few large ...
4 years, 9 months ago (2016-03-24 15:56:19 UTC) #4
bsalomon
Do we want to blacklist it from all GPU bots or just the failing MacMinis?
4 years, 9 months ago (2016-03-24 15:58:30 UTC) #5
msarett
On 2016/03/24 15:58:30, bsalomon wrote: > Do we want to blacklist it from all GPU ...
4 years, 9 months ago (2016-03-24 16:01:48 UTC) #6
Brian Osman
Only blacklisting the mac bots. (Although now it looks like there is a windows failure ...
4 years, 9 months ago (2016-03-24 16:21:01 UTC) #7
msarett
Windows failure looks flaky to me... Also I don't think it's a GPU bot?
4 years, 9 months ago (2016-03-24 16:24:44 UTC) #8
Brian Osman
On 2016/03/24 16:24:44, msarett wrote: > Windows failure looks flaky to me... Also I don't ...
4 years, 9 months ago (2016-03-24 16:31:20 UTC) #9
msarett
On 2016/03/24 16:31:20, Brian Osman wrote: > On 2016/03/24 16:24:44, msarett wrote: > > Windows ...
4 years, 9 months ago (2016-03-24 17:06:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827063004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827063004/60001
4 years, 9 months ago (2016-03-24 17:10:59 UTC) #12
msarett
On 2016/03/24 17:10:59, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 9 months ago (2016-03-24 17:23:33 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 17:33:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8c7d7ad59e3e0a56f9785456b872ed73de7a0834

Powered by Google App Engine
This is Rietveld 408576698