Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: remoting/codec/video_encoder_helper_unittest.cc

Issue 1827043004: Remove shaped desktop support from remoting host and client. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/codec/video_encoder_helper.cc ('k') | remoting/host/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/video_encoder_helper_unittest.cc
diff --git a/remoting/codec/video_encoder_helper_unittest.cc b/remoting/codec/video_encoder_helper_unittest.cc
index 569ecac6a19b5a7dda77ec62d5c05bae8625d66d..73035cc668252d3b4f4754f86085b90a231a7028 100644
--- a/remoting/codec/video_encoder_helper_unittest.cc
+++ b/remoting/codec/video_encoder_helper_unittest.cc
@@ -22,9 +22,6 @@ TEST(VideoEncoderHelperTest, PropagatesCommonFields) {
frame.set_dpi(DesktopVector(96, 97));
frame.set_capture_time_ms(20);
frame.mutable_updated_region()->SetRect(DesktopRect::MakeLTRB(0, 0, 16, 16));
- scoped_ptr<DesktopRegion> shape(
- new DesktopRegion(DesktopRect::MakeLTRB(16, 0, 32, 16)));
- frame.set_shape(shape.release());
VideoEncoderHelper helper;
scoped_ptr<VideoPacket> packet(helper.CreateVideoPacket(frame));
@@ -37,11 +34,6 @@ TEST(VideoEncoderHelperTest, PropagatesCommonFields) {
EXPECT_TRUE(packet->format().has_y_dpi());
EXPECT_EQ(1, packet->dirty_rects().size());
-
- ASSERT_TRUE(packet->has_use_desktop_shape());
- EXPECT_TRUE(packet->use_desktop_shape());
-
- EXPECT_EQ(1, packet->desktop_shape_rects().size());
}
TEST(VideoEncoderHelperTest, ZeroDpi) {
@@ -59,16 +51,6 @@ TEST(VideoEncoderHelperTest, ZeroDpi) {
EXPECT_FALSE(packet->format().has_y_dpi());
}
-TEST(VideoEncoderHelperTest, NoShape) {
- BasicDesktopFrame frame(DesktopSize(32, 32));
-
- VideoEncoderHelper helper;
- scoped_ptr<VideoPacket> packet(helper.CreateVideoPacket(frame));
-
- EXPECT_FALSE(packet->use_desktop_shape());
- EXPECT_EQ(0, packet->desktop_shape_rects().size());
-}
-
TEST(VideoEncoderHelperTest, NoScreenSizeIfUnchanged) {
BasicDesktopFrame frame(DesktopSize(32, 32));
// Set DPI so that the packet will have a format, with DPI but no size.
« no previous file with comments | « remoting/codec/video_encoder_helper.cc ('k') | remoting/host/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698