runtime/vm/disassembler.cc - Issue 182703003: Cleanup native, collected, and stub code handling in profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler.cc

Issue 182703003: Cleanup native, collected, and stub code handling in profiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler.cc

diff --git a/runtime/vm/disassembler.cc b/runtime/vm/disassembler.cc

index 044e1000247fbd6b2c144ac0d25272c2139fbc28..5b85dca36514135611b5a0773d403ef678fcbcf0 100644

--- a/runtime/vm/disassembler.cc

+++ b/runtime/vm/disassembler.cc

@@ -101,6 +101,7 @@ class FindAddrVisitor : public FindObjectVisitor {

bool Disassembler::CanFindOldObject(uword addr) {

FindAddrVisitor visitor(addr);

+ NoGCScope no_gc;

return Isolate::Current()->heap()->FindOldObject(&visitor) != Object::null();

}

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart ('k') | runtime/vm/disassembler_ia32.cc » ('j') | no next file with comments »