chrome/test/chromedriver/session_commands.cc - Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New modifications Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/client/chromedriver.py ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/session_commands.cc

diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc

index 64d9e97dc7f79c78889ab6fae712a056951e9a77..6ea77ca3ac55a081ff26f2701a48253c1e38eb65 100644

--- a/chrome/test/chromedriver/session_commands.cc

+++ b/chrome/test/chromedriver/session_commands.cc

@@ -127,6 +127,8 @@ std::unique_ptr<base::DictionaryValue> CreateCapabilities(Chrome* chrome) {

caps->SetBoolean("acceptSslCerts", true);

caps->SetBoolean("nativeEvents", true);

caps->SetBoolean("hasTouchScreen", chrome->HasTouchScreen());

+ caps->SetString("unexpectedAlertBehaviour",

+ chrome->UnexpectedAlertBehaviour());

ChromeDesktopImpl* desktop = NULL;

Status status = chrome->GetAsDesktop(&desktop);