Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4553)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New modifications Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index b4ac72d017abb0eb7d1416e1803ef90d6247a1f2..963af5b057123bc6db0017f6a49077746d34a22d 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -307,6 +307,7 @@ Status LaunchRemoteChromeSession(
chrome->reset(new ChromeRemoteImpl(std::move(devtools_http_client),
std::move(devtools_websocket_client),
*devtools_event_listeners,
+ capabilities.unexpected_alert_behaviour,
capabilities.page_load_strategy));
return Status(kOk);
}
@@ -446,6 +447,7 @@ Status LaunchDesktopChrome(
std::move(devtools_websocket_client),
*devtools_event_listeners,
std::move(port_reservation),
+ capabilities.unexpected_alert_behaviour,
capabilities.page_load_strategy,
std::move(process),
command,
@@ -530,6 +532,7 @@ Status LaunchAndroidChrome(
std::move(devtools_websocket_client),
*devtools_event_listeners,
std::move(port_reservation),
+ capabilities.unexpected_alert_behaviour,
capabilities.page_load_strategy,
std::move(device)));
return Status(kOk);

Powered by Google App Engine
This is Rietveld 408576698