chrome/test/chromedriver/chrome/chrome_desktop_impl.cc - Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New modifications Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.h » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

index 5ab7fb1efb0db91c35ad8b3972dbcb7bd3ae58ca..b555429c732da2fee70fb171b7dd394b148f44d7 100644

--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

@@ -75,6 +75,7 @@ ChromeDesktopImpl::ChromeDesktopImpl(

std::unique_ptr<DevToolsClient> websocket_client,

ScopedVector<DevToolsEventListener>& devtools_event_listeners,

std::unique_ptr<PortReservation> port_reservation,

+ std::string unexpected_alert_behaviour,

std::string page_load_strategy,

base::Process process,

const base::CommandLine& command,

@@ -85,6 +86,7 @@ ChromeDesktopImpl::ChromeDesktopImpl(

std::move(websocket_client),

devtools_event_listeners,

std::move(port_reservation),

+ unexpected_alert_behaviour,

page_load_strategy),

process_(std::move(process)),

command_(command),