Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5651)

Unified Diff: chrome/test/chromedriver/session.h

Issue 1827003004: [Chromedriver] Chromedriver should handle unexpected alert automatically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make ignore value as default & fix nits. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session.h
diff --git a/chrome/test/chromedriver/session.h b/chrome/test/chromedriver/session.h
index b582212bf16a656cc5498a839271952591482629..cee525a89292eeb184c736b0beecebfce54472c9 100644
--- a/chrome/test/chromedriver/session.h
+++ b/chrome/test/chromedriver/session.h
@@ -86,6 +86,11 @@ struct Session {
// |CommandListener|s might be |CommandListenerProxy|s that forward to
// |DevToolsEventListener|s owned by |chrome|.
ScopedVector<CommandListener> command_listeners;
+ std::string unexpected_alert_behaviour;
+ static const char kAccept[];
gmanikpure 2016/11/04 00:23:24 As discussed, adding values of unexpectedalertbeha
samuong 2016/11/22 19:52:16 these don't need to be inside the Session class, y
gmanikpure 2016/11/23 18:34:26 Done.
+ static const char kDismiss[];
+ static const char kIgnore[];
+ std::string GetUnexpectedAlertBehaviour() const;
samuong 2016/11/22 19:52:16 this is a method, so group it with the other metho
gmanikpure 2016/11/23 18:34:26 Done.
};
Session* GetThreadLocalSession();

Powered by Google App Engine
This is Rietveld 408576698