[Chromedriver] Chromedriver should handle unexpected alert automatically.

chrome/test/chromedriver/session.cc

Index: chrome/test/chromedriver/session.cc
diff --git a/chrome/test/chromedriver/session.cc b/chrome/test/chromedriver/session.cc
index 90dad58854794aff88712275670d967c0506a76b..5feb0640b81e4913f8b6b4d1b892c59e45adf497 100644
--- a/chrome/test/chromedriver/session.cc
+++ b/chrome/test/chromedriver/session.cc
@@ -57,6 +57,18 @@ Session::Session(const std::string& id, std::unique_ptr<Chrome> chrome)
 
 Session::~Session() {}
 
+//types of unexpected alert behaviour
+const char Session::kAccept[] = "accept";
+const char Session::kDismiss[] = "dismiss";
+const char Session::kIgnore[] = "ignore";
+
+std::string Session::GetUnexpectedAlertBehaviour() const {
+   if (unexpected_alert_behaviour.empty())

[samuong, 2016/11/22 19:52:16]

is it possible for this to ever be set to the empty string? if not, i think this
getter should just return |unexpected_alert_behaviour|

also, "simple" (inline) getters should be named using camel case, so you can
name this function "Session::unexpected_alert_behavior()"

[gmanikpure, 2016/11/23 18:34:26]

Empty string can be set in DesiredCapabilities
"dc.setCapability("unexpectedAlertBehaviour", "");"
But I am already checking that it should'nt be empty in
ParseUnexpectedAlertBehaviour(). Sorry, removed it.

[samuong, 2016/11/23 21:28:01]

There's no need for the "get_" prefix for this function name, you can just call
it "unexpected_alert_behavior()" as per
https://google.github.io/styleguide/cppguide.html#Function_Names

[gmanikpure, 2016/11/23 22:04:10]

Actually, I was getting multiple 'duplicate member' errors on using same
function name as the variable name "unexpected_alert_behaviour" so added "get_".
But as you suggested, I will use "unexpected_alert_behavior()" without 'u'.

[samuong, 2016/11/23 22:11:00]

Oh, I just realized that Session is a struct and not a class. You don't need a
getter at all then, just reference the variable directly.

[gmanikpure, 2016/11/23 22:24:31]

Hmm, yeah. I missed noticing that, thanks for pointing it out!
Please take a look.

+      return Session::kIgnore;
+   else
+      return unexpected_alert_behaviour;
+}
+
 Status Session::GetTargetWindow(WebView** web_view) {
   if (!chrome)
     return Status(kNoSuchWindow, "no chrome started in this session");