[Chromedriver] Chromedriver should handle unexpected alert automatically.

chrome/test/chromedriver/session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_CHROMEDRIVER_SESSION_H_
 #define CHROME_TEST_CHROMEDRIVER_SESSION_H_
 
 #include <list>
 #include <memory>
 #include <string>
@@ skipping 68 matching lines @@
   ScopedVector<WebDriverLog> devtools_logs;
   std::unique_ptr<WebDriverLog> driver_log;
   base::ScopedTempDir temp_dir;
   std::unique_ptr<base::DictionaryValue> capabilities;
   bool auto_reporting_enabled;
   // |command_listeners| should be declared after |chrome|. When the |Session|
   // is destroyed, |command_listeners| should be freed first, since some
   // |CommandListener|s might be |CommandListenerProxy|s that forward to
   // |DevToolsEventListener|s owned by |chrome|.
   ScopedVector<CommandListener> command_listeners;
+  std::string unexpected_alert_behaviour;
+  static const char kAccept[];

[gmanikpure, 2016/11/04 00:23:24]

As discussed, adding values of unexpectedalertbehaviour as constants in
session.h/session.cc.

[samuong, 2016/11/22 19:52:16]

these don't need to be inside the Session class, you can put them at the top
level instead

[gmanikpure, 2016/11/23 18:34:26]

Done.

+  static const char kDismiss[];
+  static const char kIgnore[];
+  std::string GetUnexpectedAlertBehaviour() const;

[samuong, 2016/11/22 19:52:16]

this is a method, so group it with the other methods, rather than with the
variables

[gmanikpure, 2016/11/23 18:34:26]

Done.

 };
 
 Session* GetThreadLocalSession();
 
 void SetThreadLocalSession(std::unique_ptr<Session> session);
 
 #endif  // CHROME_TEST_CHROMEDRIVER_SESSION_H_