[Chromedriver] Chromedriver should handle unexpected alert automatically.

chrome/test/chromedriver/session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/session.h"
 
 #include <list>
 #include <utility>
 
 #include "base/lazy_instance.h"
@@ skipping 39 matching lines @@
       detach(false),
       force_devtools_screenshot(false),
       chrome(std::move(chrome)),
       sticky_modifiers(0),
       mouse_position(0, 0),
       page_load_timeout(kDefaultPageLoadTimeout),
       auto_reporting_enabled(false) {}
 
 Session::~Session() {}
 
+//types of unexpected alert behaviour
+const char Session::kAccept[] = "accept";
+const char Session::kDismiss[] = "dismiss";
+const char Session::kIgnore[] = "ignore";
+
+std::string Session::GetUnexpectedAlertBehaviour() const {
+   if (unexpected_alert_behaviour.empty())

[samuong, 2016/11/22 19:52:16]

is it possible for this to ever be set to the empty string? if not, i think this
getter should just return |unexpected_alert_behaviour|

also, "simple" (inline) getters should be named using camel case, so you can
name this function "Session::unexpected_alert_behavior()"

[gmanikpure, 2016/11/23 18:34:26]

Empty string can be set in DesiredCapabilities
"dc.setCapability("unexpectedAlertBehaviour", "");"
But I am already checking that it should'nt be empty in
ParseUnexpectedAlertBehaviour(). Sorry, removed it.

[samuong, 2016/11/23 21:28:01]

There's no need for the "get_" prefix for this function name, you can just call
it "unexpected_alert_behavior()" as per
https://google.github.io/styleguide/cppguide.html#Function_Names

[gmanikpure, 2016/11/23 22:04:10]

Actually, I was getting multiple 'duplicate member' errors on using same
function name as the variable name "unexpected_alert_behaviour" so added "get_".
But as you suggested, I will use "unexpected_alert_behavior()" without 'u'.

[samuong, 2016/11/23 22:11:00]

Oh, I just realized that Session is a struct and not a class. You don't need a
getter at all then, just reference the variable directly.

[gmanikpure, 2016/11/23 22:24:31]

Hmm, yeah. I missed noticing that, thanks for pointing it out!
Please take a look.

+      return Session::kIgnore;
+   else
+      return unexpected_alert_behaviour;
+}
+
 Status Session::GetTargetWindow(WebView** web_view) {
   if (!chrome)
     return Status(kNoSuchWindow, "no chrome started in this session");
 
   Status status = chrome->GetWebViewById(window, web_view);
   if (status.IsError())
     status = Status(kNoSuchWindow, "target window already closed", status);
   return status;
 }
 
@@ skipping 45 matching lines @@
   return std::string();
 }
 
 Session* GetThreadLocalSession() {
   return lazy_tls_session.Pointer()->Get();
 }
 
 void SetThreadLocalSession(std::unique_ptr<Session> session) {
   lazy_tls_session.Pointer()->Set(session.release());
 }