Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1826973004: tracing: Add the TimeTicks clock source as trace metadata (Closed)

Created:
4 years, 9 months ago by charliea (OOO until 10-5)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing: Add the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 Committed: https://crrev.com/7a9c1264c13dd33d0e929b4477390d8ccda3cdd5 Cr-Commit-Position: refs/heads/master@{#384555}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/common/trace_event_args_whitelist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 52 (31 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/60001
4 years, 9 months ago (2016-03-24 19:34:01 UTC) #6
charliea (OOO until 10-5)
4 years, 9 months ago (2016-03-24 20:27:21 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 21:18:58 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/100001
4 years, 8 months ago (2016-03-31 15:54:59 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/24124)
4 years, 8 months ago (2016-03-31 16:04:32 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/120001
4 years, 8 months ago (2016-03-31 19:08:38 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/43193)
4 years, 8 months ago (2016-03-31 19:33:12 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/140001
4 years, 8 months ago (2016-03-31 20:05:23 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/43587)
4 years, 8 months ago (2016-03-31 20:22:01 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/160001
4 years, 8 months ago (2016-03-31 21:30:51 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/189214)
4 years, 8 months ago (2016-03-31 21:39:39 UTC) #28
Nico
https://codereview.chromium.org/1826973004/diff/160001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/1826973004/diff/160001/base/time/time.h#newcode646 base/time/time.h:646: enum class BASE_EXPORT Clock { This is incorrect; export ...
4 years, 8 months ago (2016-03-31 22:37:06 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/180001
4 years, 8 months ago (2016-03-31 23:21:57 UTC) #35
charliea (OOO until 10-5)
Good to know. Thanks Nico!
4 years, 8 months ago (2016-03-31 23:22:17 UTC) #37
oystein (OOO til 10th of July)
lgtm
4 years, 8 months ago (2016-03-31 23:32:38 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/114799) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 8 months ago (2016-03-31 23:39:23 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/200001
4 years, 8 months ago (2016-04-01 00:33:17 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203583)
4 years, 8 months ago (2016-04-01 06:35:01 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/200001
4 years, 8 months ago (2016-04-01 11:32:20 UTC) #48
commit-bot: I haz the power
Committed patchset #2 (id:200001)
4 years, 8 months ago (2016-04-01 11:57:13 UTC) #50
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 11:58:39 UTC) #52
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a9c1264c13dd33d0e929b4477390d8ccda3cdd5
Cr-Commit-Position: refs/heads/master@{#384555}

Powered by Google App Engine
This is Rietveld 408576698