|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by charliea (OOO until 10-5) Modified:
4 years, 8 months ago CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontracing: Add the TimeTicks clock source as trace metadata
This is useful when syncing Chrome traces with external traces because
we have more information to determine whether the two traces use
timestamps from the same underlying clock and can therefore be combined.
BUG=597350
Committed: https://crrev.com/7a9c1264c13dd33d0e929b4477390d8ccda3cdd5
Cr-Commit-Position: refs/heads/master@{#384555}
Patch Set 1 : #Patch Set 2 : #
Messages
Total messages: 52 (31 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== tracing: Adds the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 ========== to ========== tracing: Add the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 ==========
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/60001
charliea@chromium.org changed reviewers: + oysteine@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
thakis@chromium.org changed reviewers: + thakis@chromium.org
https://codereview.chromium.org/1826973004/diff/160001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/1826973004/diff/160001/base/time/time.h#newco... base/time/time.h:646: enum class BASE_EXPORT Clock { This is incorrect; export has no effect on enums. See https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds... ../..\base/time/time.h(646,14): error: 'dllimport' attribute only applies to variables, functions and classes [-Werror,-Wignored-attributes] enum class BASE_EXPORT Clock { ^
Patchset #1 (id:100001) has been deleted
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Patchset #1 (id:120001) has been deleted
Patchset #1 (id:140001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/180001
Patchset #1 (id:160001) has been deleted
Good to know. Thanks Nico!
oysteine@chromium.org changed reviewers: + oysteine@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/200001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oysteine@chromium.org Link to the patchset: https://codereview.chromium.org/1826973004/#ps200001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826973004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826973004/200001
Message was sent while issue was closed.
Description was changed from ========== tracing: Add the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 ========== to ========== tracing: Add the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== tracing: Add the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 ========== to ========== tracing: Add the TimeTicks clock source as trace metadata This is useful when syncing Chrome traces with external traces because we have more information to determine whether the two traces use timestamps from the same underlying clock and can therefore be combined. BUG=597350 Committed: https://crrev.com/7a9c1264c13dd33d0e929b4477390d8ccda3cdd5 Cr-Commit-Position: refs/heads/master@{#384555} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7a9c1264c13dd33d0e929b4477390d8ccda3cdd5 Cr-Commit-Position: refs/heads/master@{#384555} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
